Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup DHT tables cache on torrent removal #1289

Open
wants to merge 5 commits into
base: master
from
Open

Fix cleanup DHT tables cache on torrent removal #1289

wants to merge 5 commits into from

Conversation

@DEgITx
Copy link

DEgITx commented Feb 9, 2018

Fix bug on second adding of same torrent. After removing torrent and adding again to webtorrent it didn't search it in DHT again.
@DEgITx
fix: cleanup DHT tables cache on torrent removal
Loading status checks…
4222a53 
Fix bug on second adding of same torrent
@DEgITx DEgITx force-pushed the DEgITx:master branch from ebae8f0 to 4222a53 Feb 9, 2018
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Feb 16, 2018

Thanks for the PR! ✨Some feedback:

  • This uses a private API in bittorrent-dht. We should probably expose this functionality in the DHT API. @mafintosh - does this seem like a reasonable API addition? Is there some better way to do this?

  • Can you add a test that fails without this change, but passes with the change?
@feross
feross requested changes Feb 16, 2018
View changes
Copy link
Member

feross left a comment

See my comment
@stale

This comment has been minimized.

Sign in to view
Copy link

stale bot commented May 17, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
@stale stale bot added the stale label May 17, 2018
@feross feross added the enhancement label May 18, 2018
@stale stale bot removed the stale label May 18, 2018
@DEgITx
Merge pull request #1 from webtorrent/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fea68bb 
Master pull request
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

DiegoRBaquero commented Jul 24, 2018

@DEgITx willing to do the changes?
DEgITx added 2 commits Sep 25, 2018
@DEgITx
fix opening some files after download finished
eee6b15
@DEgITx
fix continue downloading after reopening store files
dd0d056
@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2018
@DEgITx
update discovery
Loading status checks…
e3a348f
@webtorrent webtorrent unlocked this conversation Sep 5, 2019
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Sep 5, 2019

Even though this PR needs work, I'm re-opening so it's here as a TODO since this seems like it fixes a real issue.
@feross feross reopened this Sep 5, 2019
@feross feross added the help wanted label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feross feross

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@DEgITx @feross @DiegoRBaquero
You can’t perform that action at this time.