Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd .npmignore; Move internal scripts from bin/ to scripts/ #1363
+10
−3
Conversation
By convention the bin/ folder is for user-facing command line scripts. Let's use scripts/ for internal scripts that don't need to be published.
|
Agree on the scripts change. |
This comment has been minimized.
This comment has been minimized.
|
Released as 0.99.2 |
This comment has been minimized.
This comment has been minimized.
|
FYI, I made the same change in https://github.com/webtorrent/webtorrent-cli but forgot to send a PR |
This comment has been minimized.
This comment has been minimized.
|
Gotcha |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedApr 25, 2018
By convention the bin/ folder is for user-facing command line scripts. Let's use scripts/ for internal scripts that don't need to be published.