Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix EventEmitter memory leak #1365
Conversation
This comment has been minimized.
This comment has been minimized.
|
FYI, that warning is harmless, if annoying. Honestly, I have no idea what the removed line does, hence the TODO. I'd need to re-read the code to make sure this won't break anything. We could also just merge it and see if there are new errors related to this in the WebTorrent Desktop telemetry. |
This comment has been minimized.
This comment has been minimized.
|
The line if just deferring the chunk management until Torrent fires ready. So if over 10 chunks get downloaded before the Torrent fires ready, warning will be shown. But... do we really care if torrent is not ready to store the chunk and mark the piece received, etc? Apparently not. I would just remove it. |
This comment has been minimized.
This comment has been minimized.
|
This need to be fixed by correctly organizing the methods and events. |
bricewge commentedApr 26, 2018
On some torrents, after resuming,
webtorrent-clithrow this warning:This PR seems to fix that.
It's related to #1122 and webtorrent/webtorrent-cli/issues/55.