Access-Control-Allow-Methods should be GET,HEAD #1383

feross · 2018-05-10T07:50:55Z


        Access-Control-Allow-Methods are GET,HEAD

Fixes: #1267

feross · 2018-05-10T08:00:05Z

@diracdeltas - does this look good to you?

diracdeltas · 2018-05-10T17:06:24Z

lib/server.js

@@ -111,7 +111,7 @@ function Server (torrent, opts) {
    function serveOptionsRequest () {
      res.statusCode = 204 // no content
      res.setHeader('Access-Control-Max-Age', '600')
-      res.setHeader('Access-Control-Allow-Methods', 'GET,HEAD,PUT,PATCH,POST,DELETE')
+      res.setHeader('Access-Control-Allow-Methods', 'GET,HEAD')


lgtm - do you actually need HEAD though?

We do currently support HEAD, so it needs to stay in this header if we want it to keep working. You can see how we handle it here:

webtorrent/lib/server.js

Line 209 in 8c8613d

return res.end()

I don't think it hurts to keep it.

DiegoRBaquero

Makes sense to keep only the read methods.

feross · 2018-05-10T22:38:41Z

Nice, thanks for the reviews :)

Access-Control-Allow-Methods are GET,HEAD

Loading status checks…

8c8613d

Fixes: #1267

feross mentioned this pull request May 10, 2018

Access-Control-Allow-Methods should be GET,HEAD #1267

Closed

diracdeltas reviewed May 10, 2018

View changes

diracdeltas approved these changes May 10, 2018

View changes

DiegoRBaquero approved these changes May 10, 2018

View changes

DiegoRBaquero deleted the fix-1267 branch May 10, 2018

lock bot locked as resolved and limited conversation to collaborators Aug 8, 2018

webtorrent / webtorrent

Access-Control-Allow-Methods should be GET,HEAD #1383

Access-Control-Allow-Methods should be GET,HEAD #1383

feross commented May 10, 2018

This comment has been minimized.

feross commented May 10, 2018

This comment has been minimized.

This comment has been minimized.

DiegoRBaquero left a comment

This comment has been minimized.

feross commented May 10, 2018

webtorrent / webtorrent

Sponsor webtorrent/webtorrent

Join GitHub today

Access-Control-Allow-Methods should be GET,HEAD #1383

Access-Control-Allow-Methods should be GET,HEAD #1383

Conversation

feross commented May 10, 2018

This comment has been minimized.

feross commented May 10, 2018

This comment has been minimized.

diracdeltas May 10, 2018

This comment has been minimized.

feross May 10, 2018

DiegoRBaquero left a comment

This comment has been minimized.

feross commented May 10, 2018