Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPE/MSE Implementation for WebTorrent #1384
Closed
+104
−5
Conversation
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
May 12, 2018
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
This comment has been minimized.
This comment has been minimized.
|
This looks awesome! I'll need a bit of time to dig into the changes to review them thoroughly before merging. Stay tuned! |
This comment has been minimized.
This comment has been minimized.
|
Our code could definitely be cleaner... will probably tide it up a bit if/when I have some free time in coming days. |
This comment has been minimized.
This comment has been minimized.
|
Any updates? Would also be cool to have tests. |
This comment has been minimized.
This comment has been minimized.
|
This has become outdated. Feel free to open a new PR :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
briangu33 commentedMay 12, 2018
•
edited
Implement protocol encryption (message stream encryption), alongside changes to webtorrent/bittorrent-protocol here: webtorrent/bittorrent-protocol#36.
Specification is here: https://wiki.vuze.com/w/Message_Stream_Encryption
Addresses #69. In
peer.js, when initializing a new Wire, set the third parameter of constructor (peEnabled) totrueto enable protocol encryption.