Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faq.md #1415

Merged
merged 2 commits into from Jun 20, 2018
Merged

Update faq.md #1415

merged 2 commits into from Jun 20, 2018
+2 −0

Conversation

@lovefoodcode
Copy link
Contributor

lovefoodcode commented Jun 11, 2018

No description provided.

@lovefoodcode
Update faq.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3b7b1be
@request-info

This comment has been minimized.

Sign in to view
Copy link

request-info bot commented Jun 11, 2018

👋 We would appreciate it if you could provide us with more information about this issue.

@welcome

This comment has been minimized.

Sign in to view
Copy link

welcome bot commented Jun 11, 2018

🙌 Thanks for opening this pull request! You're awesome.

@DiegoRBaquero
DiegoRBaquero approved these changes Jun 20, 2018
View changes
Copy link
Member

DiegoRBaquero left a comment

lgtm
@DiegoRBaquero
Merge branch 'master' into master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03d25e9
@DiegoRBaquero DiegoRBaquero merged commit 71fa264 into webtorrent:master Jun 20, 2018
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Node Security No known vulnerabilities found
Details
WIP ready for review
Details
@welcome

This comment has been minimized.

Sign in to view
Copy link

welcome bot commented Jun 20, 2018

🎉 Congrats on getting your first pull request landed!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DiegoRBaquero DiegoRBaquero

Assignees
No one assigned
Labels
need more info
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@lovefoodcode @DiegoRBaquero
You can’t perform that action at this time.