Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for NAT traversal techniques #1419
Closed
+205
−4
Conversation
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Jun 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Closing in favor of #1437 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

oleiba commentedJun 17, 2018
Extending the PR #1051, by allowing to specify specific protocol (TCP/UDP) for a NAT traversal technique.
This is important in particular for the case of registering a DHT port as UDP.
I here add the original author's comments for clarity: