Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NAT traversal techniques #1419

Closed
wants to merge 18 commits into from
Closed

Conversation

@oleiba
Copy link

oleiba commented Jun 17, 2018

Extending the PR #1051, by allowing to specify specific protocol (TCP/UDP) for a NAT traversal technique.
This is important in particular for the case of registering a DHT port as UDP.

I here add the original author's comments for clarity:

Here is an implementation of NAT traversal as discussed in #195 using https://github.com/indutny/node-nat-upnp and https://github.com/TooTallNate/node-nat-pmp.

I have also ecountered https://github.com/level451/pmp that claims to make both UPnP ad NAT-PMP but I don't have tested it.

This feature is implemented in a new module for node env only and provided by a single instance shared by the webtorrent clients because NAT-PMP needs to open a specific port to work.

I checked the UPnP part with my router by it does not support NAT-PMP protocol.

The mappings are sent both with UPnP and NAT-PMP whe available and refreshed every 30 min.

Reviews are welcome!

yciabaud and others added 10 commits Feb 18, 2017
NAT traversal
@welcome

This comment has been minimized.

Copy link

welcome bot commented Jun 17, 2018

🙌 Thanks for opening this pull request! You're awesome.

oleiba added 5 commits Jun 17, 2018
@oleiba

This comment has been minimized.

Copy link
Author

oleiba commented Jul 20, 2018

Closing in favor of #1437

@oleiba oleiba closed this Aug 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.