Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updata-attribute DOM API with client.render() to activate #1421
Conversation
This comment has been minimized.
This comment has been minimized.
|
I feel that this should be outside of the library. @feross ? |
This comment has been minimized.
This comment has been minimized.
|
I'm gonna follow my gut and keep this outside the main lib. But this should be a module on its own, so please release it and link it in the docs :) |
This comment has been minimized.
This comment has been minimized.
|
I think this might actually be a good idea to include in WebTorrent core. I haven't looked into the specific approach that this PR took, but the idea of making WebTorrent possible to use without writing any JS is a good idea. I talked a little about it here: https://youtu.be/E1RxSzbmMO0?t=1367 I'll re-open this PR as a place holder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
KayleePop commentedJun 20, 2018
•
edited
Flems demo
Issue: #879