Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-attribute DOM API with client.render() to activate #1421

Open
wants to merge 3 commits into
base: master
from

Conversation

@KayleePop
Copy link
Contributor

KayleePop commented Jun 20, 2018

Flems demo

Issue: #879

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

DiegoRBaquero commented Jul 24, 2018

I feel that this should be outside of the library. @feross ?

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

DiegoRBaquero commented Aug 29, 2018

I'm gonna follow my gut and keep this outside the main lib. But this should be a module on its own, so please release it and link it in the docs :)

@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2018
@webtorrent webtorrent unlocked this conversation Sep 5, 2019
@feross

This comment has been minimized.

Copy link
Member

feross commented Sep 5, 2019

I think this might actually be a good idea to include in WebTorrent core. I haven't looked into the specific approach that this PR took, but the idea of making WebTorrent possible to use without writing any JS is a good idea. I talked a little about it here: https://youtu.be/E1RxSzbmMO0?t=1367

I'll re-open this PR as a place holder.

@feross feross reopened this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.