Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brfs to the latest version 🚀 #1422

Merged
merged 1 commit into from Jul 24, 2018
Merged

Conversation

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Jun 22, 2018

Version 2.0.0 of brfs was just published.

Dependency [brfs](https://github.com/substack/brfs)
Current Version 1.6.1
Type devDependency

The version 2.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of brfs.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes v2.0.0

Update to static-module 3. This adds scope tracking, and keeps fs requires around if they are still used.

Scope tracking

Previously the below:

var fs = require('fs')
function x (fs) { return fs.readFileSync(__filename) }
x({ readFileSync: function () { return 10 } })

would compile the fs.readFileSync() call, even though it's not actually referring to the fs module. This may seem contrived but it can happen easily if a file was minified before being passed to brfs, and a million different variables are all named e.

Retain used requires

Previously the below:

var fs = require('fs')
fs.readFileSync(someDynamicValue())
fs.readFileSync(__filename)

would compile to:

fs.readFileSync(someDynamicValue())
Buffer('...', 'base64')

But now it compiles to:

var fs = require('fs')
fs.readFileSync(someDynamicValue())
Buffer('...', 'base64')

This is primarily helpful when bundling for node or electron.

Commits

The new version differs by 5 commits.

  • 7e13064 2.0.0
  • 5920e0f Add Node 10 to CI.
  • 27be82e Add test for scope tracking features in static-module@3
  • a365cb7 Merge pull request #89 from browserify/static-module-3
  • 8149ee7 Update static-module to v3 with scope tracking.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@greenkeeper greenkeeper bot added the greenkeeper label Jun 22, 2018
Copy link
Member

DiegoRBaquero left a comment

LGTM

@DiegoRBaquero DiegoRBaquero merged commit 2e42220 into master Jul 24, 2018
7 checks passed
7 checks passed
Node Security No known vulnerabilities found
Details
WIP ready for review
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
greenkeeper/verify Greenkeeper verified pull request
Details
@DiegoRBaquero DiegoRBaquero deleted the greenkeeper/brfs-2.0.0 branch Jul 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.