Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTorrent to pass discovery interval to torrent-discovery #1436
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'll take this with added documentation and tests |
|
See comment |
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Nov 27, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
oleiba commentedJul 20, 2018
torrent-discoverysupports acceptingintervalMsin its constructor, for changing the interval for discovering new peers (e.g. querying the DHT).However, passing this argument is not yet supported in the main WebTorrent client which uses this package. This PR enables it.
Sometimes it makes a lot of sense to adjust the interval of querying the DHT for updates, for example if you want shorter discovery intervals than the 15 minutes default.