Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NAT traversal techniques #1437

Open
wants to merge 20 commits into
base: master
from

Conversation

@oleiba
Copy link

oleiba commented Jul 20, 2018

Extending the PR #1051, by allowing to specify specific protocol (TCP/UDP) for a NAT traversal technique.
This is important in particular for the case of registering a DHT port as UDP.

I here add the original author's comments for clarity:

Here is an implementation of NAT traversal as discussed in #195 using https://github.com/indutny/node-nat-upnp and https://github.com/TooTallNate/node-nat-pmp.

I have also ecountered https://github.com/level451/pmp that claims to make both UPnP ad NAT-PMP but I don't have tested it.

This feature is implemented in a new module for node env only and provided by a single instance shared by the webtorrent clients because NAT-PMP needs to open a specific port to work.

I checked the UPnP part with my router by it does not support NAT-PMP protocol.

The mappings are sent both with UPnP and NAT-PMP whe available and refreshed every 30 min.

Reviews are welcome!

yciabaud and others added 13 commits Feb 18, 2017
NAT traversal
oleiba added 7 commits Sep 6, 2018
@stale

This comment has been minimized.

Copy link

stale bot commented Dec 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 5, 2018
@stale stale bot closed this Dec 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2019
@webtorrent webtorrent unlocked this conversation Aug 10, 2019
@feross feross reopened this Aug 10, 2019
@stale stale bot removed the stale label Aug 10, 2019
@feross feross added the enhancement label Aug 10, 2019
@mayeaux

This comment has been minimized.

Copy link

mayeaux commented Feb 4, 2020

I was told this functionality is working, can anyone confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.