Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bittorrent-protocol to the latest version 🚀 #1447

Merged
merged 2 commits into from Jul 27, 2018

Conversation

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Jul 27, 2018

Version 3.0.0 of bittorrent-protocol was just published.

Dependency bittorrent-protocol
Current Version 2.4.2
Type dependency

The version 3.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of bittorrent-protocol.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 9 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@greenkeeper greenkeeper bot added the greenkeeper label Jul 27, 2018
@DiegoRBaquero

This comment has been minimized.

Copy link
Member

DiegoRBaquero commented Jul 27, 2018

We need to use new keyword

greenkeeper bot added a commit that referenced this pull request Jul 27, 2018
@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

greenkeeper bot commented Jul 27, 2018

Version 3.0.1 just got published.

Update to this version instead 🚀

Commits

The new version differs by 3 commits.

See the full diff

@feross

This comment has been minimized.

Copy link
Member

feross commented Jul 27, 2018

@DiegoRBaquero Actually, we are using the new keyword everywhere. It looks like the issue is that WebConn is a subclass of Wire (i.e. bittorrent-protocol). So we need to convert WebConn to an ES6 class.

@feross

This comment has been minimized.

Copy link
Member

feross commented Jul 27, 2018

Just converted WebConn to ES6, will merge once the tests all pass.

@feross
feross approved these changes Jul 27, 2018
Copy link
Member

feross left a comment

Tests are passing now, so this worked!

@feross feross merged commit 6978433 into master Jul 27, 2018
5 checks passed
5 checks passed
WIP ready for review
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@feross feross deleted the greenkeeper/bittorrent-protocol-3.0.0 branch Jul 27, 2018
@feross

This comment has been minimized.

Copy link
Member

feross commented Jul 27, 2018

0.101.1

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.