Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd package-lock.json to gitignore #1455
Merged
+1
−0
Conversation
|
Had this discussion with @feross we ended with globally git ignore package-lock.json, makes sense to put it in there for others. |
This comment has been minimized.
This comment has been minimized.
|
Yep, this makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
KayleePop commentedAug 1, 2018
Seems like a good idea since npm automatically creates it.
At the very least it would remove a minor annoyance