Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small debugging improvements #1464

Merged
merged 1 commit into from Aug 9, 2018
Merged

Small debugging improvements #1464

merged 1 commit into from Aug 9, 2018

Conversation

@jhiesey
Copy link
Contributor

jhiesey commented Aug 9, 2018

These were useful when I was doing some debugging and probably will help others too.

Copy link
Contributor

KayleePop left a comment

LGTM

I think that if (this.destroyed) return is a mistake because _debug() is actually called after this.destroyed is set to true in torrent._destroy() here

webtorrent/lib/torrent.js

Lines 666 to 672 in f01ca68

Torrent.prototype._destroy = function (err, cb) {
var self = this
if (self.destroyed) return
self.destroyed = true
self._debug('destroy')
self.client._remove(self)

@feross
feross approved these changes Aug 9, 2018
Copy link
Member

feross left a comment

LGTM

@feross feross merged commit e0cae41 into webtorrent:master Aug 9, 2018
3 checks passed
3 checks passed
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@feross

This comment has been minimized.

Copy link
Member

feross commented Aug 9, 2018

Released as 0.102.1

@jhiesey

This comment has been minimized.

Copy link
Contributor Author

jhiesey commented Aug 9, 2018

@KayleePop yup that's exactly the issue I hit

@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.