Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize lib/file.js #1478

Merged
merged 2 commits into from Aug 20, 2018
Merged

modernize lib/file.js #1478

merged 2 commits into from Aug 20, 2018

Conversation

@jimmywarting
Copy link
Contributor

jimmywarting commented Aug 20, 2018

es6 syntax
@jimmywarting
modernize lib/file.js
Loading status checks…
36d4e07
@jimmywarting
wrapped in parentheses
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6386a6e
@jimmywarting jimmywarting mentioned this pull request Aug 20, 2018
Closed
@DiegoRBaquero
DiegoRBaquero approved these changes Aug 20, 2018
View changes
Copy link
Member

DiegoRBaquero left a comment

Perfect, thanks!
@DiegoRBaquero DiegoRBaquero merged commit 52f5700 into webtorrent:master Aug 20, 2018
3 checks passed
3 checks passed
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Sign in to view
Copy link

welcome bot commented Aug 20, 2018

🎉 Congrats on getting your first pull request landed!

@jimmywarting jimmywarting deleted the jimmywarting:feature/modernize branch Aug 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DiegoRBaquero DiegoRBaquero

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jimmywarting @DiegoRBaquero
You can’t perform that action at this time.