Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcalculate file downloaded correctly #1479
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
Could you maybe add a test where it fails with current code and works with your PR? |
This comment has been minimized.
This comment has been minimized.
|
Done |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
I'm glad you could figure the tests out |
This comment has been minimized.
This comment has been minimized.
|
Thanks, i have never tried tape before, and i didn't know i needed to look into webtorrent-fixtures but I am good at reverse engineering :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jimmywarting commentedAug 20, 2018
I notice
file.downloadis calculated wrong.Using the Sintel torrent as an example...
https://instant.io/#08ada5a7a6183aae1e09d831df6748d566095a10
(this can be tested in the console)
It has 6 srt files and 1 small piece of the mp4 file in the first piece
after the first piece is downloaded you can see that the first files are complete but the
progressanddownloadedare incorrect