Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTry to reduce dl impact on slow computers (web) #1513
Merged
Conversation
On slow computers with a fast network, web browsers may no longer respond because webtorrent is downloading chunks too fast. The main issue is that you cannot stream a torrent video: the web browser does not have time to play the video, it is too busy downloading the video chunks. On web browser supporting [requestIdleCallback](https://developer.mozilla.org/en-US/docs/Web/API/Window/requestIdleCallback#See_also), we download chunks with a lower priority allowing the web browser to execute other tasks (like playing the video).
|
I like this. LGTM |
Chocobozzz
added a commit
to Chocobozzz/PeerTube
that referenced
this pull request
Oct 1, 2018
webtorrent client dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Chocobozzz commentedSep 21, 2018
•
edited
On slow computers with a fast network, web browsers may no longer respond because webtorrent is downloading chunks too fast.
The main issue is that you cannot stream a video torrent: the web browser does not have time to play the video, it is too busy downloading the video chunks.
On web browser supporting requestIdleCallback, we download chunks with a lower priority allowing the web browser to execute other tasks (like playing the video).