Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global download and upload limit #1516

Open
wants to merge 6 commits into
base: master
from

Conversation

@kdiogenes
Copy link

kdiogenes commented Sep 25, 2018

I updated PR #1040 with the current code base. I will start to look for the test suite soon.

chtrinh and others added 6 commits Feb 11, 2017
@welcome

This comment has been minimized.

Copy link

welcome bot commented Sep 25, 2018

🙌 Thanks for opening this pull request! You're awesome.

@kdiogenes kdiogenes changed the title Global download an upload limit Global download and upload limit Sep 25, 2018
@stale

This comment has been minimized.

Copy link

stale bot commented Dec 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 24, 2018
@JacerOmri

This comment has been minimized.

Copy link

JacerOmri commented Dec 26, 2018

I thought this was merged before i started working on a PR for webtorrent-desktop to add controls for this.
I would love to see the problems with this PR fixed so we can move forward. Especially that those errors are very simple.
I think you should remove the conflicting .min.js file and correct some linting issues:

standard: Run `standard --fix` to automatically fix some problems.
  /home/travis/build/webtorrent/webtorrent/index.js:102:31: A space is required after '{'.
  /home/travis/build/webtorrent/webtorrent/index.js:102:56: A space is required before '}'.
  /home/travis/build/webtorrent/webtorrent/index.js:103:29: A space is required after '{'.
  /home/travis/build/webtorrent/webtorrent/index.js:103:52: A space is required before '}'.
  /home/travis/build/webtorrent/webtorrent/lib/peer.js:95:1: Trailing spaces not allowed.
  /home/travis/build/webtorrent/webtorrent/lib/peer.js:99:13: Missing space before function parentheses.
  /home/travis/build/webtorrent/webtorrent/lib/peer.js:104:19: Missing space before function parentheses.

And that's about it :)

@stale stale bot removed the stale label Dec 26, 2018
@stale

This comment has been minimized.

Copy link

stale bot commented Mar 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Mar 26, 2019
@stale stale bot closed this Apr 2, 2019
@Kylart

This comment has been minimized.

Copy link

Kylart commented Apr 15, 2019

Do we have any update on this? It seems it would fix #163 which would be awesome for most user imo.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2019
@webtorrent webtorrent unlocked this conversation Aug 12, 2019
@feross feross reopened this Aug 12, 2019
@stale stale bot removed the stale label Aug 12, 2019
@feross feross added the enhancement label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.