Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate relative urls in server.js #1598

Closed
wants to merge 1 commit into from
Closed

Conversation

@last-g
Copy link

last-g commented Mar 21, 2019

This change will allow using server behind a reverse proxy.

This change will allow using server behind a reverse proxy.
@welcome

This comment has been minimized.

Copy link

welcome bot commented Mar 21, 2019

🙌 Thanks for opening this pull request! You're awesome.

@Fenny

This comment has been minimized.

Copy link

Fenny commented May 15, 2019

This is exactly what I need

Copy link
Member

alxhotel left a comment

Tested with the following configuration in NGINX and webtorrent server listening at port 37717:

location /proxy/ {
	proxy_pass http://localhost:37717/;
}

Works as expected.

@feross

This comment has been minimized.

Copy link
Member

feross commented Sep 7, 2019

Thanks for the PR @last-g. Thanks for reviewing and testing it @alxhotel.

The code in this file changed, so there's now a merge conflict. I just manually made this change and released 0.107.10.

@feross feross closed this Sep 7, 2019
feross added a commit that referenced this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.