Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAllows customization of webseed http requests through an options call… #1613
+5
−1
Conversation
…back function.
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Apr 9, 2019
This comment has been minimized.
This comment has been minimized.
gruns
commented
Apr 9, 2019
•
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
Is this something that we would want to have if we changed to using fetch instead of simple-get? |
This comment has been minimized.
This comment has been minimized.
Sure why not. Regardless of which API handles http requests, I think allowing custom http options is important. |
This comment has been minimized.
This comment has been minimized.
|
Where is the issue where fetch was discussed? |
This comment has been minimized.
This comment has been minimized.
|
Think there is none |
This comment was marked as off-topic.
This comment was marked as off-topic.
Fenny
commented
May 15, 2019
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

guanzo commentedApr 9, 2019
•
edited
…back function.
This pull request allows users to modify the http options passed to
simple-get, such as adding headers, query parameters, etc.torrentOptsnow accepts agetWebseedOptscallback function, similar togetAnnounceOpts.Relevant issues:
#1507
#1530