Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows customization of webseed http requests through an options call… #1613

Open
wants to merge 2 commits into
base: master
from

Conversation

@guanzo
Copy link
Contributor

guanzo commented Apr 9, 2019

…back function.

This pull request allows users to modify the http options passed to simple-get, such as adding headers, query parameters, etc. torrentOpts now accepts a getWebseedOpts callback function, similar to getAnnounceOpts.

Relevant issues:
#1507
#1530

@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 9, 2019

🙌 Thanks for opening this pull request! You're awesome.

@gruns

This comment has been minimized.

Copy link

gruns commented Apr 9, 2019

+1

@jimmywarting

This comment has been minimized.

Copy link
Contributor

jimmywarting commented Apr 9, 2019

Is this something that we would want to have if we changed to using fetch instead of simple-get?
Is there anyone interested in using fetch instead?

@guanzo

This comment has been minimized.

Copy link
Contributor Author

guanzo commented Apr 9, 2019

Is this something that we would want to have if we changed to using fetch instead of simple-get?

Sure why not. Regardless of which API handles http requests, I think allowing custom http options is important.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

DiegoRBaquero commented Apr 9, 2019

Where is the issue where fetch was discussed?

@jimmywarting

This comment has been minimized.

Copy link
Contributor

jimmywarting commented Apr 10, 2019

Think there is none
But I brought it up in #1507

@Fenny

This comment was marked as off-topic.

Copy link

Fenny commented May 15, 2019

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.