Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upReturn server from server.listen for method chaining to work #1641
Conversation
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Jun 17, 2019
|
|
This comment has been minimized.
This comment has been minimized.
|
I had fixed returning server, but I prefer your version :). Thank you! |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Sep 10, 2019
|
|
This comment has been minimized.
This comment has been minimized.
|
0.107.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tryzniak commentedJun 17, 2019
Hi! This should fix webtorrent/webtorrent-cli#101 and webtorrent/webtorrent-cli#100. There was some breaking change in #1547. We used to return server for method chaining, to do stuff like
server.listen(...).on('error...'), and it broke. This PR fixes everything back to normal.