Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFix error in Chrome extension environment #1675
Merged
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
Released as 0.105.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedJul 23, 2019
Video streaming is broken in Brave since they upgraded to WebTorrent v0.105.0. The root cause is described in this issue: brave/brave-browser#5358
This is a quick fix. Once we drop support for Node, we can purge
require('url')from across the codebase and just use the globalURLeverywhere. So, this fix can be removed then without affecting Brave.Fixes brave/brave-browser#5358