Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix server 'hostname' option to mitigate DNS rebinding attack #1678
Conversation
lib/server.js
Outdated
| @@ -218,6 +218,11 @@ function Server (torrent, opts = {}) { | |||
| const html = getPageHTML('405 - Method Not Allowed', '<h1>405 - Method Not Allowed</h1>') | |||
| res.end(html) | |||
| } | |||
|
|
|||
| function serveEmptyResponse () { | |||
| res.statusCode = 204 | |||
This comment has been minimized.
This comment has been minimized.
feross
Jul 30, 2019
Author
Member
Ideally, we'd just kill the whole TCP connection without responding at all but I'm not sure if there's a clean way to do this from the http layer. Looking into it.
This comment has been minimized.
This comment has been minimized.
|
lgtm |
It appears that this feature, originally added in #1260, never worked correctly. When the request hostname does not match the user-provided opts.hostname value, we should stop processing the request and return nothing. Instead, what was happening was that we'd simply omit the Access-Control-Allow-Origin header, which is not sufficient since the whole point of DNS rebinding attacks is that they appear same origin and therefore don't require a CORS header.
This comment has been minimized.
This comment has been minimized.
|
Nice, figured out how to kill the connection without sending a response. Merging now. |
This comment has been minimized.
This comment has been minimized.
|
0.105.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedJul 30, 2019
•
edited
It appears that this feature, originally added in #1260, may have never worked correctly.
When the request hostname does not match the user-provided opts.hostname value, we should stop processing the request and return nothing. Instead, what was happening was that we'd simply omit the Access-Control-Allow-Origin header, which is not sufficient since the whole point of DNS rebinding attacks is that they appear to be same origin and therefore don't require a CORS header.
cc @diracdeltas @yrliou