Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for end < start #1679

Merged
merged 1 commit into from Aug 4, 2019
Merged

Conversation

@ddumont
Copy link
Contributor

ddumont commented Aug 1, 2019

No description provided.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 1, 2019

🙌 Thanks for opening this pull request! You're awesome.

@request-info

This comment has been minimized.

Copy link

request-info bot commented Aug 1, 2019

👋 We would appreciate it if you could provide us with more information about this issue.

@feross
feross approved these changes Aug 4, 2019
Copy link
Member

feross left a comment

LGTM, thanks!

@feross feross merged commit e4d79e5 into webtorrent:master Aug 4, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 4, 2019

🎉 Congrats on getting your first pull request landed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.