Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Knuth shuffle #169
Merged
Fix Knuth shuffle #169
Conversation
charlescharles
force-pushed the
charlescharles:charles/knuth-shuffle
branch
from
83fa930
to
42b8f93
charlescharles
force-pushed the
charlescharles:charles/knuth-shuffle
branch
from
42b8f93
to
2c4bac0
This comment has been minimized.
This comment has been minimized.
|
This is pretty funny. I'm sitting here with @dcposch who was talking about mixcoin and then we noticed this PR was from you. Thanks, dude! |
This comment has been minimized.
This comment has been minimized.
|
No problem! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
charlescharles commentedOct 28, 2014
randomly noticed while browsing the code -- switching each element with a random element of the entire array isn't a random shuffle. see http://stackoverflow.com/a/7291502
@feross