Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upApp "chromeapp" field to `package.json` #1691
Merged
+8
−0
Conversation
I'm attempting to make a defacto standard for specifying Chrome App dependency substitutions using the `"chromeapp"` field in `package.json`. The `"chromeapp"` field is just like the [`"browser"` field in `package.json`](https://github.com/defunctzombie/package-browser-field-spec) except it's intended for Chrome Apps instead of a generic browser environment. Bundler tools like `browserify` or `webpack` can be configured to look for the `"chromeapp"` field instead of the `"browser"` field when doing a build for a Chrome App. In this specific package, since Chrome Apps can use raw sockets we want to replace e.g. `require('net')` with `require('chrome-net')`.
This comment has been minimized.
This comment has been minimized.
|
This will be part of 0.108.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedAug 8, 2019
•
edited
For: brave/brave-browser#5587
I'm attempting to make a defacto standard for specifying Chrome App dependency substitutions using the
"chromeapp"field inpackage.json.The
"chromeapp"field is just like the"browser"field inpackage.jsonexcept it's intended for Chrome Apps instead of a generic browser environment. Bundler tools likebrowserifyorwebpackcan be configured to look for the"chromeapp"field instead of the"browser"field when doing a build for a Chrome App.In this specific package, since Chrome Apps can use raw sockets we want to replace e.g.
require('net')withrequire('chrome-net').I'm also sending PRs to all dependent projects that need substitutions to work in Chrome Apps.