Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds missing callback. #1694
Merged
Adds missing callback. #1694
+1
−1
Conversation
|
LGTM. Sorry I previously broke this! |
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Aug 8, 2019
|
|
This comment has been minimized.
This comment has been minimized.
|
0.107.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
guanzo commentedAug 8, 2019
•
edited
torrent._verifyPieces()is missing a callback invocation. Currently it hangs forever. I reached the conditional after callingtorrent.rescanFiles(), which I believe is buggy and will file an issue for.