Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple remove/add calls for a torrent object #1699

Closed
wants to merge 1 commit into from
Closed

Allow multiple remove/add calls for a torrent object #1699

wants to merge 1 commit into from

Conversation

@ddumont
Copy link
Contributor

ddumont commented Aug 9, 2019

torrent object were created each time, even if torrentId was already a torrent.
@ddumont
Allow multiple remove/add calls for a torrent object
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
75485bc 
torrent object were created each time, even if torrentId was already a torrent.
@ddumont

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ddumont commented Aug 9, 2019

ugh... looks like the state of the torrent after remove is borked...
I think i need to do this another way
@ddumont

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ddumont commented Aug 9, 2019

removing the torrent and then adding back the old torrent.torrentFile gets the workflow working, however it loses the data from the previously downloaded torrent... any ideas?
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Sep 11, 2019

You can pass a path option to the same location and WebTorrent will reuse the files that already exist there. You can look at webtorrent-desktop for an example of how to do this.
@feross feross closed this Sep 11, 2019
@ddumont

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ddumont commented Sep 11, 2019

@feross any thoughts on a method like pause that actually halts all traffic? I wouldn't have to remove, re-add then
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Sep 11, 2019 •
edited

Not a bad idea. I don't have bandwidth to write it now, but would like to get to this eventually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ddumont @feross
You can’t perform that action at this time.