Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updestroy videostream (if any) when file is destroyed. #1704
Conversation
| @@ -119,7 +119,7 @@ class File extends EventEmitter { | |||
|
|
|||
| renderTo (elem, opts, cb) { | |||
| if (typeof window === 'undefined') throw new Error('browser-only method') | |||
| render.render(this, elem, opts, cb) | |||
| this._stream = render.render(this, elem, opts, cb) | |||
This comment has been minimized.
This comment has been minimized.
feross
Aug 14, 2019
Member
See feedback on your PR to render-media, but this won't work if render doesn't return a Videostream instance and instead uses one of the other strategies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ddumont commentedAug 12, 2019
for use with feross/render-media#70 to clean up errors