Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadding add funding.yaml option through Unlock for donations with Ethe… #1713
Conversation
…reum
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Aug 26, 2019
This comment has been minimized.
This comment has been minimized.
|
@julien51 Thanks for the PR. I think this sounds really cool, but I'm skeptical that enough folks will be able to figure this out that it's worth it. And I don't really have a problem of folks trying to censor my donations. It's already hard to get anyone to donate using "normal" payment methods. Adding in the extra complexity of blockchain doesn't seem like it will improve the situation here. Who is your product for? I support the cause of trying out new things. But honestly, it seems like a lot of work. How would I easily convert these funds into dollars or at least something like bitcoin or ether? |
This comment has been minimized.
This comment has been minimized.
|
Hey @feross , thanks for the feedback.
Now, the bigger question about "why". The large answer is "programability" (is this a word?). By decoupling the "donation" from the platform itself, this means that anyone could easily show donation happening here on their 3rd party site. For example you can see I made a donation because I have a key to this specific lock. Another idea that we have is that by using a lock it really becomes easy to "pool" resources from multiple repos, even through different users. I am not sure if you're familiar with the idea of DAO, but we wrote about how "pooling" donations on a single "foundation-like" organization could look like. |

julien51 commentedAug 26, 2019
•
edited
Hello!
First of all, thanks for your (hard) work on WebTorrent @feross.
It is fantastic to see open source developers contribute immense value through their work and it is also very exciting to see all your work on the "funding OSS" movement. You're leading by example and this is why I am opening this Pull Request!
At Unlock, we're building a protocol for memberships. This means a thousand things, but one example that we think of a lot, is around making "donations" or "sponsorships". A sponsor, donor is a member of a very unique club: the club of people/organizations which help someone do their work "for free" for the rest of the world.
One key aspect of protocols is that they need to be "permission-less" which means that, like Torrent, HTTP or git, they do not require someone else's permission to be used. Memberships should be permission-less too.
Unlock uses the Ethereum blockchain which means that it is "unstoppable" (even, most importantly by us). When a creator uses Unlock to create their membership(s), no one can stop people from becoming members.
This Pull Requests adds the ability to contribute to your work using a Lock. This Lock is a smart contract deployed at
0x7567Ce8bBEb821AA39883f4E80f75DA605FdD394. For now, it is owned by me, but if you decide to move forward I want to transfer it to you (just send me an Ethereum address!). After that, it is yours only and nobody else can alter or change its behavior.It is currently set to sell keys using the following characteristics [we mimicked what you had on your WebTorrent Supporter level]:
One someone purchases a key, they will receive a unique token to represent their donation/membership. This token is what people call a Non Fungible Token.
Before going on, I think it would be important to check that your existing sponsor button would not conflict with the
FUNDING.ymlfile that this PR adds.I am more than happy to answer question and listen to feedback. Please feel free to reach out.
Finally, here is what it looks like:
PS: I have purchased a key, so there are 10DAI on the lock already ;) and you can see my NFT using any NFT store, such as OpenSea.