Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http server XSS #1714

Merged
merged 3 commits into from Aug 27, 2019
Merged

Fix http server XSS #1714

merged 3 commits into from Aug 27, 2019
Commits on Aug 27, 2019
  1. Fix http server XSS

    feross committed Aug 27, 2019
    Low risk xss. If the torrent contains a specially crafted title or file name, and the user starts the WebTorrent HTTP server via createServer(), and then the user visits the HTTP server index page (which lists the contents of the torrent), then the attacker can run JavaScript in this browser context.
    
    The reason this seems relatively low risk is that the WebTorrent HTTP server only allows fetching data pieces from the torrent. It doesn't support any other control of the torrent client. So, attacker code could e.g. figure out what content the user is downloading and exfiltrate that to an external domain.
    
    This commit mitigates the issue in two ways (either of which could have prevented this XSS on its own):
    
    1. HTML-escape untrusted torrent metadata (name, path, file names, etc.)
    
    2. Add the strictest possible CSP to prevent all connections, scripts, styles, plugins, frames. Every capability is denied.
  2. Set security headers on /favicon.ico responses

    feross committed Aug 27, 2019
  3. Address @diracdeltas feedback on #1714

    feross committed Aug 27, 2019
You can’t perform that action at this time.