Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEmit `metadata` before `ready` and `done` #1737
Merged
Conversation
|
This seems like a good change to me. I guess this got moved into the wrong place after the PRs changing the verification process? Would be nice to add a test for this too, if you have the time. |
This comment has been minimized.
This comment has been minimized.
|
Released as 0.107.8 |
feross
added a commit
that referenced
this pull request
Sep 7, 2019
Fixes: webtorrent/webtorrent-cli#112 Fix for PR #1737
This comment has been minimized.
This comment has been minimized.
|
This PR broke Released as 0.107.9 |
alxhotel
added a commit
to alxhotel/webtorrent
that referenced
this pull request
Sep 7, 2019
alxhotel
added a commit
to alxhotel/webtorrent
that referenced
this pull request
Sep 7, 2019
alxhotel
added a commit
to alxhotel/webtorrent
that referenced
this pull request
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alxhotel commentedSep 6, 2019
•
edited
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Regarding events, I think it is important the order in which they are emitted.
If I'm correct, the usual order in which
torrentevents are emitted should be:But right now, the
metadataevent is emitted the last one. This PR fixes the order of this event. And maybe fixes webtorrent-desktop#1429. I'm not sure since I was not able to reproduce the bug with the exact same steps. But, at least, the order is now (as I believe) correct.Is there anything you'd like reviewers to focus on?
They should focus on staying awesome ;)