Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix how the first piece's irrelevant bytes are calculated #1738
+8
−6
Conversation
This comment has been minimized.
This comment has been minimized.
|
0.107.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedSep 7, 2019
•
edited
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
Noticed that the fix to use modulo on the offset from #1592 wasn't applied to the second case.
Is there anything you'd like reviewers to focus on?
Nope