Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd tests to check the order of torrent events #1739
Conversation
|
This is excellent! Thanks!! |
This comment has been minimized.
This comment has been minimized.
|
I just realised that the build fails because the tests don't pass in the browser, although I'm not sure why the browser tests weren't executed in the PR checks... Anyhow, this line does not work in the browser (obviously): webtorrent/test/torrent-events.js Line 29 in 84fb338 And it must be moved inside the I guess there are two options:
This brings me to another question: why aren't there any tests for downloading and seeding in the browser? Or am I missing something? |
This comment has been minimized.
This comment has been minimized.
|
A lot of the tests are node-only. I think we can solve this by moving the test to the node folder for now. This is still a lot better than not having this test. We can figure out how to solve the webtrc peer issue separately. We don't run the browser tests in PRs since there is a secret API keys required to interact with Saucelabs and travis doesn't expose those environment variables to PRs since then anyone could send a PR and just log out the secret API key. It's not ideal, but it makes some sense. |
This comment has been minimized.
This comment has been minimized.
Ah got it
Great!
Thanks for fixing this |
alxhotel commentedSep 7, 2019
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain: Tests
What changes did you make? (Give an overview)
This PR adds tests for #1737
Is there anything you'd like reviewers to focus on?