Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to override default download path #174

Merged
merged 4 commits into from Nov 3, 2014

Conversation

@ghost
Copy link

ghost commented Nov 2, 2014

This allows people to override the default download path to a writable directory of their choice if needed. Here's a demonstration:

$ webtorrent --download "/media/E099" "magnet link"

Referencing issue: #172

opfl added 2 commits Nov 2, 2014
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Nov 2, 2014

I decided to change the name of the command to 'download' to avoid any confusion

opfl
@feross

This comment has been minimized.

Copy link
Member

feross commented Nov 2, 2014

Thanks! This looks good, but can we change the flag to -o and --out? I think that's more standard for terminal programs.

opfl
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Nov 2, 2014

Done

feross added a commit that referenced this pull request Nov 3, 2014
Added command to override default download path
@feross feross merged commit c670b51 into webtorrent:master Nov 3, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@feross

This comment has been minimized.

Copy link
Member

feross commented Nov 3, 2014

Thanks for the quick fix! Merged and published as 0.12.0.

@feross feross mentioned this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.