Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refractor torrent to make it easier to add new sources #177

Closed
wants to merge 3 commits into from

Conversation

@miketamis
Copy link

miketamis commented Nov 8, 2014

moved the storage creation into a module ‘torrent-manager’ this will
allow for further source to be added easily.

Mike Tamis added 2 commits Nov 8, 2014
moved the storage creation into a module ‘torrent-manager’ this will
allow for further source to be added easily.
Mike Tamis
@chrisaljoudi

This comment has been minimized.

Copy link
Contributor

chrisaljoudi commented Nov 17, 2014

Mind elaborating what you mean by "adding new sources"? I couldn't immediately till by the diffs.

@miketamis

This comment has been minimized.

Copy link
Author

miketamis commented Nov 17, 2014

for example iv been working on adding webseed (http seeds)
this is the bit of code I added to torrentManager to add webseed.
TorrentManager still needs alot of work as you noted yourself its not very clear. but this is the first step.

torrentManager.prototype.storageReady = function() {
  var self = this
  self.torrent.attachStorage(self.storage);
+ self.webseed = new Webseed(self, self.storage, self.parsedTorrent);
}
@feross

This comment has been minimized.

Copy link
Member

feross commented Nov 27, 2014

Hey @miketamis, I'm really sorry but you could you rebase this PR? It's my fault that I took so long to review it that now it doesn't merge cleanly. I would rebase myself, but it looks like it might take significant work since you did a lot of code moving and you are more likely to get it right.

While you're at it, it might be easier to evaluate these changes if you also added web seeding in the same PR, since that's why we're doing this in the first place :)

Thanks, and my bad!

@feross

This comment has been minimized.

Copy link
Member

feross commented Dec 7, 2014

@miketamis Ping?

@miketamis

This comment has been minimized.

Copy link
Author

miketamis commented Dec 7, 2014

Sorry been real busy trying to push out an app for a client. Ill have a look at it tonight i'v forgotten how far I had gotten, I think it was all working in most scenarios but not all.

@feross

This comment has been minimized.

Copy link
Member

feross commented Dec 8, 2014

@miketamis Cool, looking forward to checking it out.

@feross

This comment has been minimized.

Copy link
Member

feross commented Jul 7, 2015

Sorry this PR never got merged, but it's way out of date now so I'm going to close it.

@feross feross closed this Jul 7, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.