Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uprefractor torrent to make it easier to add new sources #177
Conversation
This comment has been minimized.
This comment has been minimized.
|
Mind elaborating what you mean by "adding new sources"? I couldn't immediately till by the |
This comment has been minimized.
This comment has been minimized.
|
for example iv been working on adding webseed (http seeds) torrentManager.prototype.storageReady = function() {
var self = this
self.torrent.attachStorage(self.storage);
+ self.webseed = new Webseed(self, self.storage, self.parsedTorrent);
} |
This comment has been minimized.
This comment has been minimized.
|
Hey @miketamis, I'm really sorry but you could you rebase this PR? It's my fault that I took so long to review it that now it doesn't merge cleanly. I would rebase myself, but it looks like it might take significant work since you did a lot of code moving and you are more likely to get it right. While you're at it, it might be easier to evaluate these changes if you also added web seeding in the same PR, since that's why we're doing this in the first place :) Thanks, and my bad! |
This comment has been minimized.
This comment has been minimized.
|
@miketamis Ping? |
This comment has been minimized.
This comment has been minimized.
|
Sorry been real busy trying to push out an app for a client. Ill have a look at it tonight i'v forgotten how far I had gotten, I think it was all working in most scenarios but not all. |
This comment has been minimized.
This comment has been minimized.
|
@miketamis Cool, looking forward to checking it out. |
This comment has been minimized.
This comment has been minimized.
|
Sorry this PR never got merged, but it's way out of date now so I'm going to close it. |
miketamis commentedNov 8, 2014
moved the storage creation into a module ‘torrent-manager’ this will
allow for further source to be added easily.