Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove commented-out links #1772
Merged
Conversation
The inclusion of HTML comments was breaking the markdown rendering on https://webtorrent.io/faq. If the links get fixed for these URLs, they can be added back from the git history.
Closed
|
Thanks! (don't mind the failing build) Would it work to move the comments to below the list instead of deleting them? |
This comment has been minimized.
This comment has been minimized.
|
Sure thing. I'll clone webtorrent.io and test to make sure that moving them to the bottom doesn't disrupt the HTML generation |
Move removed comments to the end of the list
This comment has been minimized.
This comment has been minimized.
|
@KayleePop confirmed moving the comments to the bottom works without disrupting the rest of the HTML |
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DeltaF1 commentedOct 29, 2019
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
I removed some commented-out URLs from the "Who is using WebTorrent today?" section of the FAQ. The inclusion of HTML comments was breaking the markdown rendering. If the links get fixed for these URLs, they can be added back from the git history.
Which issue (if any) does this pull request address?
#1771