Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade end-of-stream to v1.4.1 #1804

Merged
merged 1 commit into from Jan 3, 2020
Merged

downgrade end-of-stream to v1.4.1 #1804

merged 1 commit into from Jan 3, 2020

Conversation

@KayleePop
Copy link
Contributor

KayleePop commented Jan 3, 2020

The minor update in our version range was breaking. We can update it later when it's fixed.

even without an NPM bump, this patch is useful to just let the CI tests work

issue: #1757 (should maybe keep that open until we can re-enable updates for the package though)

this issue too: #1748

The minor update in our version range was breaking. We can update it later when it's fixed. 

even without an NPM bump, this is patch is useful to just let the CI tests work

issue: #1757 (should maybe keep that open until we can re-enable updates for the package though)
Copy link
Member

alxhotel left a comment

Yes! Thanks @KayleePop for proposing this temporal fix, you've read my mind.

@KayleePop KayleePop merged commit edf1cf0 into master Jan 3, 2020
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@KayleePop KayleePop deleted the downgrade-end-of-stream branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.