Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed `--remove` and `--no-quit`; replaced w/ inference. Solves #181. #184

Merged
merged 1 commit into from Nov 19, 2014
Merged

Removed `--remove` and `--no-quit`; replaced w/ inference. Solves #181. #184

merged 1 commit into from Nov 19, 2014

Conversation

@chrisaljoudi
Copy link
Contributor

chrisaljoudi commented Nov 17, 2014

This removes the two command line options --remove and --no-quit and. Instead, inference is used:

  • If an output file is specified, WebTorrent won't remove the files after termination/after torrent is done.
  • WebTorrent will now keep running if it's streaming (Chromecast, AirPlay, HTTP server, etc.) but only if it sees at least one request to the server coming.
    • In other words, if an HTTP server is instantiated but it never gets any requests, WebTorrent will choose to terminate after the download is done.
@chrisaljoudi
Removed `--remove` and `--no-quit`; replaced with inference. Resolves…
Loading status checks…
6d31100 
… issue #181.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Nov 19, 2014

This looks good. Thanks!
feross added a commit that referenced this pull request Nov 19, 2014
@feross
Merge pull request #184 from chrisaljoudi/master
Loading status checks…
9d0ac16 
Removed `--remove` and `--no-quit`; replaced w/ inference. Solves #181.
@feross feross merged commit 9d0ac16 into webtorrent:master Nov 19, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@feross feross mentioned this pull request Nov 19, 2014
Closed
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@chrisaljoudi @feross
You can’t perform that action at this time.