Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output more details #188

Merged
merged 4 commits into from Nov 25, 2014
Merged

Output more details #188

merged 4 commits into from Nov 25, 2014

Conversation

@astro
Copy link
Contributor

astro commented Nov 22, 2014

More clutter, but helps understanding the webtorrent download progress.

You could drop the last commit (12cbf81) if the performance impact is too big.

@astro

This comment has been minimized.

Copy link
Contributor Author

astro commented Nov 22, 2014

I don't insist on this PR but on the other hand I don't know where the console interface should be headed. I kinda like the rtorrent UI.

@feross

This comment has been minimized.

Copy link
Member

feross commented Nov 25, 2014

Thanks for the PR! I like the idea of showing more information in the console UI.

I'll merge this now and we can work on the performance of the last commit before I publish a new version. If it's not salvageable, we can always revert the last commit.

feross added a commit that referenced this pull request Nov 25, 2014
Output more details
@feross feross merged commit a4d9592 into webtorrent:master Nov 25, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@feross

This comment has been minimized.

Copy link
Member

feross commented Nov 27, 2014

This PR didn't affect perf at all on my machine :)

Released as 0.15.0.

@astro

This comment has been minimized.

Copy link
Contributor Author

astro commented Nov 27, 2014

Iterating through all wires times all pieces has quite a complexity. We could cache progress per wire and drop it with each bitfield and have message.

@feross

This comment has been minimized.

Copy link
Member

feross commented Nov 28, 2014

Yep, good idea. I'd accept a PR that did this :)

On Fri Nov 28 2014 at 5:16:35 AM Astro notifications@github.com wrote:

We could cache progress per wire and drop it with each bitfield and have
message.


Reply to this email directly or view it on GitHub
#188 (comment).

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.