Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upOutput more details #188
Output more details #188
Conversation
This comment has been minimized.
This comment has been minimized.
|
I don't insist on this PR but on the other hand I don't know where the console interface should be headed. I kinda like the rtorrent UI. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! I like the idea of showing more information in the console UI. I'll merge this now and we can work on the performance of the last commit before I publish a new version. If it's not salvageable, we can always revert the last commit. |
This comment has been minimized.
This comment has been minimized.
|
This PR didn't affect perf at all on my machine :) Released as 0.15.0. |
This comment has been minimized.
This comment has been minimized.
|
Iterating through all wires times all pieces has quite a complexity. We could cache |
This comment has been minimized.
This comment has been minimized.
|
Yep, good idea. I'd accept a PR that did this :) On Fri Nov 28 2014 at 5:16:35 AM Astro notifications@github.com wrote:
|
astro commentedNov 22, 2014
More clutter, but helps understanding the webtorrent download progress.
You could drop the last commit (12cbf81) if the performance impact is too big.