Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed Uncaught TypeError #191
Closed
Conversation
I was getting `Uncaught TypeError: Cannot read property 'name' of undefined` with `client.seed(files)` in the browser. In `createTorrent`, opts.name is read from without checking if opts exists. (Maybe this fix should go in the `create-torrent` module?)
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! I made this change in webtorrent/create-torrent@08e11a5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ArtskydJ commentedNov 27, 2014
I was getting
Uncaught TypeError: Cannot read property 'name' of undefinedwithclient.seed(files)in the browser.The error was being thrown in the
createTorrentmodule:opts.nameis read from without checking ifoptsexists. Should this fix should go in thecreate-torrentmodule?