Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport seeding a file from filesystem (path string) #209
Conversation
feross
changed the title
This comment has been minimized.
This comment has been minimized.
Why am I sending a PR to my own project?In the spirit of OPEN Open Source, I am going to start sending pull requests for new features and non-trivial changes to WebTorrent. This way, the community (that's you!) get a chance to read the code and share feedback before it becomes a part of WebTorrent |
This comment has been minimized.
This comment has been minimized.
a0viedo
commented
Dec 17, 2014
|
That's a great idea and iniciative, @feross. |
This comment has been minimized.
This comment has been minimized.
mafintosh
commented
Dec 17, 2014
|
|
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review @mafintosh! Merged. |
feross
added a commit
that referenced
this pull request
Dec 17, 2014
Support seeding a file from filesystem (path string)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedDec 16, 2014
This is a first pass at supporting seeding a file from filesystem (path string), for issue #197.
I'll send a separate PR to support seeding entire folders.
Code review welcome.