Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate client version string from package.json version #212

Merged
merged 2 commits into from Dec 18, 2014
Merged

Generate client version string from package.json version #212

merged 2 commits into from Dec 18, 2014

Conversation

@feross
Copy link
Member

feross commented Dec 17, 2014

Depends on this PR: webpro/versionify#2 (already merged and released)
feross added 2 commits Dec 17, 2014
@feross
Generate client version string from package.json version
Loading status checks…
1473113 
Depends on this PR: webpro/versionify#2
@feross
set client version in node too
Loading status checks…
1293fbd
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

feross commented Dec 18, 2014

Merging this now because this updates browserify to v7, which fixes an issue that a user in #webtorrent was seeing (Uncaught TypeError: Cannot read property 'on' of undefined).
feross added a commit that referenced this pull request Dec 18, 2014
@feross
Merge pull request #212 from feross/versionify
Loading status checks…
519a8ba 
Generate client version string from package.json version
@feross feross merged commit 519a8ba into master Dec 18, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

feross commented Dec 18, 2014

Wow, okay, the real cause of this Uncaught TypeError: Cannot read property 'on' of undefined error was really weird. At first, I thought this was the require('stream') cyclic dependency bug that we've seen before #179 and was fixed in 0.13.1. cc @mafintosh

But in reality, this was caused by uglifyjs renaming function names. I was depending on Function.name in bittorrent-protocol to determine the protocol extension's name. Bad idea. Fixed here: webtorrent/bittorrent-protocol@0b09424
@feross feross deleted the versionify branch Dec 22, 2014
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@feross
You can’t perform that action at this time.