Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Piece.verify method and update README #240

Merged
merged 1 commit into from Jan 9, 2015
Merged

fix Piece.verify method and update README #240

merged 1 commit into from Jan 9, 2015

Conversation

@n1t0
Copy link

n1t0 commented Jan 8, 2015

Since sha1 is now async, this was failing with the following error:

.../node_modules/webtorrent/node_modules/simple-sha1/index.js:6
    cb(hash)
    ^
TypeError: undefined is not a function
    at .../node_modules/webtorrent/node_modules/simple-sha1/index.js:6:5
    at process._tickCallback (node.js:419:13)

I also updated the README to add some available options when adding a torrent.
Anthony MOI
fix Piece.verify method and update README with options available when…
Loading status checks…
f3b84a6 
… adding a torrent
feross added a commit that referenced this pull request Jan 9, 2015
@feross
Merge pull request #240 from n1t0/master
Loading status checks…
b2428b8 
fix Piece.verify method and update README
@feross feross merged commit b2428b8 into webtorrent:master Jan 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Jan 9, 2015

Thanks, released as 0.22.1.
@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@n1t0 @feross
You can’t perform that action at this time.