Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd <audio> tag streaming support for mp3 files #245
Merged
Conversation
| @@ -99,12 +99,15 @@ FileStream.prototype.pipe = function (dst) { | |||
| var self = this | |||
| var pipe = stream.Readable.prototype.pipe | |||
|
|
|||
| if (dst && dst.nodeName === 'VIDEO') { // <video> tag | |||
| if (dst && dst.nodeName === 'VIDEO' || dst.nodeName === 'AUDIO') { // <video> and <audio> tag | |||
This comment has been minimized.
This comment has been minimized.
feross
Jan 16, 2015
Member
The if statement should be dst && (dst.nodeName === 'VIDEO' || dst.nodeName === 'AUDIO') because of order of operations and dst could be undefined. I'll fix.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Awesome, thanks! |
feross
added a commit
that referenced
this pull request
Jan 16, 2015
Add <audio> tag streaming support for mp3 files
This comment has been minimized.
This comment has been minimized.
|
Thanks! This was a simple change with awesome results! Released as webtorrent@0.26.0 and deployed to https://instant.io |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mathiasvr commentedJan 16, 2015
Quick fix for issue #201