Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upStorage leakfix #251
Storage leakfix #251
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hmmm... something is breaking the fs-storage tests. |
This comment has been minimized.
This comment has been minimized.
|
Honestly, I would like to keep the piece backing buffer separated in blocks so we can persist them away ASAP, to lift pressure from the GC. |
This comment has been minimized.
This comment has been minimized.
|
I would like to know your opionion on the idea. I've got a preliminary implementation here: |
This comment has been minimized.
This comment has been minimized.
|
I'd like to merge this, but I'm trying to debug why this causes the tests to fail. |
This comment has been minimized.
This comment has been minimized.
|
I couldn't figure out why the tests are failing, so I had to revert merging this. I'll take another look soon. |
astro commentedJan 21, 2015
For your consideration, attempts to solve #248