Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage leakfix #251

Merged
merged 3 commits into from Jul 8, 2015
Merged

Storage leakfix #251

merged 3 commits into from Jul 8, 2015

Conversation

@astro
Copy link
Contributor

astro commented Jan 21, 2015

For your consideration, attempts to solve #248

@astro astro mentioned this pull request Jan 21, 2015
@astro

This comment has been minimized.

Copy link
Contributor Author

astro commented Jan 21, 2015

Hmmm... something is breaking the fs-storage tests.

@astro

This comment has been minimized.

Copy link
Contributor Author

astro commented Jan 21, 2015

Honestly, I would like to keep the piece backing buffer separated in blocks so we can persist them away ASAP, to lift pressure from the GC.

@astro astro mentioned this pull request Jan 23, 2015
@astro

This comment has been minimized.

Copy link
Contributor Author

astro commented Jan 23, 2015

I would like to know your opionion on the idea. I've got a preliminary implementation here:
https://github.com/astro/webtorrent/tree/per-block-buffers
Block structures cause quite some overhead, so we'll need different handling for pieces with a blank/written state. My experiment has shown really low memory usage by partially loaded pieces. This will benefit performance whenever we can move received data off memory, ie. to files or IndexedDB.

@feross feross mentioned this pull request Jun 24, 2015
@feross

This comment has been minimized.

Copy link
Member

feross commented Jul 7, 2015

I'd like to merge this, but I'm trying to debug why this causes the tests to fail.

@feross

This comment has been minimized.

Copy link
Member

feross commented Jul 8, 2015

I couldn't figure out why the tests are failing, so I had to revert merging this. I'll take another look soon.

@feross feross merged commit b9e9603 into webtorrent:master Jul 8, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.