Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upContinuous hashing #252
Closed
Continuous hashing #252
Conversation
bin/cmd.js
Outdated
| } | ||
| clivas.line('{4+cyan:' + i + '} ' + bar); | ||
| linesremaining -= 1 | ||
| } | ||
| clivas.line( | ||
| '{red:storage mem:} {bold:' + Math.ceil(storageMem / 1024) + ' KB} ' |
This comment has been minimized.
This comment has been minimized.
feross
Jan 23, 2015
Member
We should use the prettyBytes function instead of calculating this manually.
This comment has been minimized.
This comment has been minimized.
Merged
bin/cmd.js
Outdated
| bar += '{green:█}'; | ||
| } else { | ||
| switch(piece.blocks[j]) { | ||
| case 0: |
This comment has been minimized.
This comment has been minimized.
feross
Jan 23, 2015
Member
Should export the constants from storage.js so we don't have magic numbers here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
astro commentedJan 21, 2015
Based on #251. Fixes #237 and provides groundwork for #235.