Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow to cancel reserve on unwritten blocks #272
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
Good catch! I believe this fixes #266, which is a bug I've been trying to track down for a while. You're the bomb! |
feross
added a commit
that referenced
this pull request
Feb 19, 2015
Allow to cancel reserve on unwritten blocks
This comment has been minimized.
This comment has been minimized.
|
Released as webtorrent@0.27.2 |
This was referenced Feb 19, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
grunjol commentedFeb 18, 2015
Trying to figure out why #266 happens and after debugging using the #267 PR, it seems like the cancelBlock is called as you mention here #253 but if the block is the first in the piece and was never written, the 'reserve' is never really canceled because the buffer is null (because is lazy initialized)