Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upshould remove part of memory leaks closures for callback in event listen... #282
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. How did you measure that these changes actually reduce memory usage? How can I confirm on my machine? |
2ef7cc9
to
cd22aa1
This comment has been minimized.
This comment has been minimized.
|
I did not make any mesures for this. This case https://cloud.githubusercontent.com/assets/69734/5448999/74155c90-8505-11e4-9dd4-afbf7cb99ce6.png revealed to me that code has not any unsubscribtion for events. But them should be because it common case for memory leaks So this should fix not only part of confirmed leaks, but also just potential leaks |
This comment has been minimized.
This comment has been minimized.
|
Why did you close the issue? |
This comment has been minimized.
This comment has been minimized.
|
I commited from fork master where I plan to make more changes. (so i did) I want to make new pull request from other branch (wich I still did not make) |
This comment has been minimized.
This comment has been minimized.
d68650f
to
eb2d4ab
afc7059
to
ee46b42
arestov commentedMar 18, 2015
...ers in foreight objects