Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesextension support #363
extension support #363
Conversation
This comment has been minimized.
This comment has been minimized.
|
Yes, this is good idea. Without this, the only way to use a custom protocol extension is to send a PR to webtorrent core, or to use However, I'd rather emit Eventually, we might want to add an var MyExtension = require('./my-extension')
torrent.on('wire', function (wire) {
wire.use(MyExtension)
}) |
This comment has been minimized.
This comment has been minimized.
|
Released as 0.50.0. |
This comment has been minimized.
This comment has been minimized.
|
I wasn't super happy with the onWire option. I was thinking maybe |
madd512 commentedJun 25, 2015
I made this thing support extensions. Thoughts?